Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup-sbt to workflow #434

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

codingWithRach
Copy link
Contributor

What does this change?

Adds setup-sbt to workflow

Note that setup-scala was not used due to a discrepancy between the java-version in setup-java and that in the pre-existing .tool-versions file

How to test

Workflow ran successfully on this branch

How can we measure success?

No failing workflows when Github takes sbt away from us!

Have we considered potential risks?

Images

Accessibility

Copy link

github-actions bot commented Nov 6, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit ac3154b. ± Comparison against base commit f2bf69c.

Copy link
Member

@JustinPinner JustinPinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me but I see the PR is still draft. Are you having problems with it?

@codingWithRach codingWithRach marked this pull request as ready for review November 7, 2024 08:14
@codingWithRach codingWithRach requested a review from a team as a code owner November 7, 2024 08:14
@codingWithRach
Copy link
Contributor Author

This looks OK to me but I see the PR is still draft. Are you having problems with it?

No, I didn't want to change it to Ready for review until I'd checked that the workflows passed, and was merely forgetful!

@emdash-ie emdash-ie merged commit 4e1abf1 into main Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants